Fix editor hover style margins when Draw Extra Borders is enabled #88652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content margins for FlatMenuButton and RunBarButton are now handled correctly when the "Draw Extra Borders" user option is enabled
|
Thanks! |
|
@RobProductions It looks like this change is still needed for the bottom panel, as letters get cut off otherwise:
|
|
@Calinou strange, I can't seem to reproduce that on the build I compiled before submitting the PR:
I tried with the setting on and off, in multiple themes, with the compact preset, and after restarting Godot but I don't see it. I'll take a look at the bottom panel code & try rebuilding on latest master soon to see if something changed. If it's not something on master, is there anything else that could cause the spacing to be different between our two setups? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88644
The slight movement seen in the videos provided by @Calinou was caused by a difference in
content_marginthat was only apparent when the Draw Extra Borders option is enabled. I introduced some extra styles in #86378 and didn't test how they were affected with this option on, apologies for the regression. I've now modified the styles so that the margin matches the "normal" stylebox (for FlatMenuButton and MainScreenButton) which fixes the movement issue:Capture2024-02-21.21-25-38.mov
I also added in the correct theme type variation to the "Mono build" button in order to stop the border from appearing in the normal state. Let me know if there's anything else I should account for here, thanks!